Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Dialog&Drawer): support beforeOpen And beforeClose API #3203

Merged
merged 10 commits into from
Nov 19, 2024
Merged

feat(Dialog&Drawer): support beforeOpen And beforeClose API #3203

merged 10 commits into from
Nov 19, 2024

Conversation

Wesley-0808
Copy link
Contributor

🤔 这个 PR 的性质是？

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

feat(Dialog): 新增beforeOpen、beforeClose API
feat(Drawer): 新增beforeOpen、beforeClose API

  • fix(组件名称): 处理问题或特性描述 ...

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项。⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 14, 2024 •
edited
Loading

完成

@HaixingOoO
Copy link
Collaborator

@uyarn 佬，代码没问题，你看看帮他处理类型和一些api是没有的问题吧，估计是把整个文件覆盖了

@Wesley-0808
Copy link
Contributor Author

@uyarn 佬，代码没问题，你看看帮他处理类型和一些api是没有的问题吧，估计是把整个文件覆盖了

类型那些事API平台出的 我再看看咋回事

@Wesley-0808
Copy link
Contributor Author

Wesley-0808 commented Nov 15, 2024 •
edited
Loading

@uyarn 佬，代码没问题，你看看帮他处理类型和一些api是没有的问题吧，估计是把整个文件覆盖了

我本地装依赖装半天 看看build能行不

@HaixingOoO
Copy link
Collaborator

@uyarn 佬，代码没问题，你看看帮他处理类型和一些api是没有的问题吧，估计是把整个文件覆盖了

我本地装依赖装半天 看看build能行不

你这样，回退到原来的文件(组件的文件不用回退，就回退md、type、defaultProps)，自己再把新增的api加到对应的文件(md，type)，不要直接覆盖文件，就没问题了

@Wesley-0808
Copy link
Contributor Author

@uyarn 佬，代码没问题，你看看帮他处理类型和一些api是没有的问题吧，估计是把整个文件覆盖了

我本地装依赖装半天 看看build能行不

你这样，回退到原来的文件(组件的文件不用回退，就回退md、type、defaultProps)，自己再把新增的api加到对应的文件(md，type)，不要直接覆盖文件，就没问题了

ok好的

@Wesley-0808
Copy link
Contributor Author

得嘞

@Wesley-0808
Copy link
Contributor Author

Wesley-0808 commented Nov 15, 2024 •
edited
Loading

approval最后一个工作流吧

@Wesley-0808
Copy link
Contributor Author

@uyarn 这个还有什么问题吗？

@uyarn
Copy link
Collaborator

uyarn commented Nov 18, 2024

@uyarn 这个还有什么问题吗？

这两天会合并

@uyarn
Copy link
Collaborator

uyarn commented Nov 19, 2024

@HaixingOoO 你看看还有没有什么问题

@uyarn uyarn merged commit ca02d7d into Tencent:develop Nov 19, 2024
7 checks passed
@github-actions github-actions bot mentioned this pull request Nov 28, 2024
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HaixingOoO HaixingOoO HaixingOoO approved these changes

@uyarn uyarn uyarn approved these changes

@honkinglin honkinglin Awaiting requested review from honkinglin honkinglin is a code owner

@carolin913 carolin913 Awaiting requested review from carolin913 carolin913 is a code owner

@NWYLZW NWYLZW Awaiting requested review from NWYLZW NWYLZW is a code owner

@ZWkang ZWkang Awaiting requested review from ZWkang ZWkang is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Wesley-0808 @HaixingOoO @uyarn